Avoid Global Data
Global data leads to unintended side effects between functions and can make code difficult or impossible to parallelize. Even if the code is not intended today for parallelization, there is no reason to make it impossible for the future.
Besides being global data, statics are not always constructed and deconstructed as you would expect. This is particularly true in cross-platform environments. See for example, this g++ bug regarding the order of destruction of shared static data loaded from dynamic modules.
std::shared_ptr is “as good as a global” because it allows multiple pieces of code to interact with the same data.
Singletons (often implemented with a static and/or
shared_ptr) should never be used in NebulaStream.
Avoid Heap Operations
Much slower in threaded environments. In many or maybe even most cases, copying data is faster. Plus with move operations and such and things.
Mutex and Mutable Go Together (M&M rule, C++11)
For member variables it is good practice to use mutex and mutable together. This applies in both ways:
A mutable member variable is presumed to be a shared variable, so it should be synchronized with a mutex (or made atomic)
If a member variable is itself a mutex, it should be mutable. This is required to use it inside a const member function.